[AI-FSSDK] (DO NOT REVIEW) [FSSDK-12262] Exclude CMAB from UserProfileService#12
Closed
[AI-FSSDK] (DO NOT REVIEW) [FSSDK-12262] Exclude CMAB from UserProfileService#12
Conversation
Exclude CMAB experiments from User Profile Service (UPS) sticky bucketing logic. CMAB experiments require dynamic decisions based on current user attributes and TTL, which contradicts UPS's behavior of maintaining decisions across experiment lifetime. Changes: - Modified decision_service.py to skip UPS read/write for CMAB experiments - Added test to verify CMAB experiments don't use UPS - All existing tests pass (28/28) Quality Assurance: - Tests Passed: 28/28 (100%) - New test: test_get_variation_cmab_experiment_excludes_user_profile_service - Code review: No issues found - Backward compatibility: Confirmed Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Excludes CMAB (Contextual Multi-Armed Bandit) experiments from User Profile Service (UPS) sticky bucketing logic.
Jira Ticket: FSSDK-12262
Problem
CMAB experiments require dynamic decisions based on current user attributes and TTL, which contradicts UPS's behavior of maintaining decisions across the experiment lifetime without considering these factors.
Solution
Modified
decision_service.pyto exclude CMAB experiments from UPS logic:Changes Made
and not experiment.cmabcondition to both UPS read and write checkstest_get_variation_cmab_experiment_excludes_user_profile_serviceto verify exclusionQuality Assurance
Test Results:
Code Review:
Test Plan
pytest tests/test_decision_service.py::DecisionServiceTestpytest tests/test_decision_service.py -k cmabpytest tests/test_decision_service.py::DecisionServiceTest::test_get_variation_cmab_experiment_excludes_user_profile_service🤖 Generated with Claude Code